Repository navigation
Studio P0: preserve SV/PTP milestone; exact 4I+4V START snapshot and polished operator layout - #240
Conversation
…policy, cancellable by OFF
…tacked layout and PTP defaults
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a3ea46efb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| RowLayout { | ||
| ColumnLayout { |
There was a problem hiding this comment.
When the --check-operator-ui acceptance runs, the two full-width matrices now have approximately the same left and right edges, but checkOperatorViewport() in apps/arstack_studio/src/main.cpp:85-88 still requires the voltage matrix's right edge to precede the current matrix's left edge. Thus every tested viewport reports a panel-order violation and exits with code 21; update that native contract to validate vertical voltage-before-current ordering along with this layout change.
AGENTS.md reference: AGENTS.md:L249-L257
Useful? React with 👍 / 👎.
| const accepted = smartSession.requestStartWithScenario( | ||
| controller.startScenarioSnapshot()) |
There was a problem hiding this comment.
The Qt CI job directly runs check_operator_workspace.py, whose existing assertion searches for the contiguous text requestStartWithScenario(controller.startScenarioSnapshot()); splitting this call across these lines makes that test fail with “reconnect must not auto-transmit, but one-click Start must stage a bounded scenario.” Keep the call contiguous or update the older assertion to recognize the multiline form so the required regression gate passes.
AGENTS.md reference: AGENTS.md:L249-L257
Useful? React with 👍 / 👎.
| tone === "success" ? "#d6f4e6" : | ||
| tone === "danger" ? "#ffdce0" : | ||
| tone === "accent" ? "#dcebff" : theme.textSoft | ||
| tone === "accent" ? "#dcebff" : hovered ? "#142334" : theme.textSoft |
There was a problem hiding this comment.
When a focused neutral button is activated with Space or Enter while the pointer is elsewhere, down selects the new light #d6e3f1 fill but hovered remains false, so this expression retains the light theme.textSoft caption and makes it nearly unreadable. Treat down like hovered when selecting the dark caption color.
Useful? React with 👍 / 👎.
|
Release cleanup · 2026-10-23 — CLOSED AS SUPERSEDED UI DESIGN (NOT MERGED). Original branch head: At canonical #286 head The multiple competing 2026-10-17 UI implementations cannot be merged into current Studio without overwriting the latest operator layout and the other active worker's automatic Live-edit/Enter/focus-out fix. Preserve the unique historical design and regression rationale here; #286 owns the current premium UI and exact-build release gate. Desktop 100/150/175% DPI visual acceptance and physical GUI→SV angles/phase verification remain pending, not marked PASS. In particular #239 stays OPEN because its RUNNING three-phase toggle changes actual channel values contract differs from the current preference-only switch and must be independently dispositioned. No changes to |
Operator screenshot 2026-10-17 22:14: PTP SOURCE + AUTO local synchronization with continuous
smpCnt, SV packet capture differs from previously displayed table. This UI-only PR stacked on phase-sync-qualified M3 baseline does not edit any firmware or IEC 61850 core files.startScenarioSnapshot()of the current full 4I+4V table, regardless of priorpendingApplystate. Eliminates accidental reuse of stale device values after stopped/restart. Existing live row editing remains unchanged; evidence of actual board acceptance still needs wire capture.AUTO, Phasor ON and Wave ON. PTP SOURCE now queued once after verified device becomes ready, bounded to 36 seconds, explicit OFF cancels the in-session intent. It does not auto-start SV output or fake a PTP lock.SMV–PTP baseline frozen: no changes to
embedded/,include/ariec61850/time_sync/or packet encoding/phase logic, and the next packaged firmware must be exact-commit matched, servo+MAC evidence enabled, mirror OFF. CI Qt, Windows lifecycle, native preview, protocol tests and firmware builds must pass before merge.